parthchandra commented on code in PR #4169:
URL: https://github.com/apache/arrow-rs/pull/4169#discussion_r1186326433
##########
arrow-cast/src/cast.rs:
##########
@@ -947,8 +956,8 @@ pub fn cast_with_options(
x as f64 / 10_f64.powi(*scale as i32)
})
}
- Utf8 => value_to_string::<i32>(array),
- LargeUtf8 => value_to_string::<i64>(array),
+ Utf8 => value_to_string::<i32>(array, None),
Review Comment:
This is a decimal to string and `FormatOptions` only has format specifiers
for temporal types. I don't see a need to specify format for decimal since the
display is precisely determined by the precision and scale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
