parthchandra commented on code in PR #4169:
URL: https://github.com/apache/arrow-rs/pull/4169#discussion_r1187974218
##########
arrow-cast/src/cast.rs:
##########
@@ -947,8 +956,8 @@ pub fn cast_with_options(
x as f64 / 10_f64.powi(*scale as i32)
})
}
- Utf8 => value_to_string::<i32>(array),
- LargeUtf8 => value_to_string::<i64>(array),
+ Utf8 => value_to_string::<i32>(array, None),
Review Comment:
I've added the format option for decimal types as well, but
[decimal_display](https://github.com/apache/arrow-rs/blob/5e2350a9804201407c33d9ecd5fa90d598b52cfb/arrow-cast/src/display.rs#L408)
will drop this option.
I don't know if there is a standard or common way to specify a format string
for decimals used by other engines, but I'll take a look at it sometime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
