candiduslynx opened a new pull request, #35481:
URL: https://github.com/apache/arrow/pull/35481
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Currently there's a gotcha to use `array.FixedSizeListBuilder.AppendNull`:
you have to manually append null values to the underlying list.
This changes this behavior to match the one of
`array.FixedSizeListBuilder.AppendEmptyValue` that handles it by itself.
### What changes are included in this PR?
Add `AppendNull` call to the values builder in
`array.FixedSizeListBuilder.AppendNull`.
### Are these changes tested?
Yes, the `Example_fixedSizeListArray` was modified to express the changed
behavior.
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.**
Added `AppendNull` call to the values builder in
`array.FixedSizeListBuilder.AppendNull`.
Previously, manually adding these calls was required.
After this change a simple `array.FixedSizeListBuilder.AppendNull` is enough
to maintain the correct indices.
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
