zeroshade commented on code in PR #35481:
URL: https://github.com/apache/arrow/pull/35481#discussion_r1187646724


##########
go/arrow/array/fixed_size_list.go:
##########
@@ -207,6 +207,9 @@ func (b *FixedSizeListBuilder) Append(v bool) {
 func (b *FixedSizeListBuilder) AppendNull() {

Review Comment:
   Can you just add a docstring comment here that mentions this will add the 
null values to the underlying value builder? Since this is a breaking change i 
want to make sure the documentation updates accordingly to ensure people can 
understand why their code broke. (if they don't read the changelog when v13 
gets released haha).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to