WillAyd commented on code in PR #658:
URL: https://github.com/apache/arrow-adbc/pull/658#discussion_r1187915216
##########
c/driver/sqlite/sqlite_test.cc:
##########
@@ -90,6 +90,68 @@ class SqliteConnectionTest : public ::testing::Test,
};
ADBCV_TEST_CONNECTION(SqliteConnectionTest)
+TEST_F(SqliteConnectionTest, GetInfoMetadata) {
+ ASSERT_THAT(AdbcConnectionNew(&connection, &error),
+ adbc_validation::IsOkStatus(&error));
+ ASSERT_THAT(AdbcConnectionInit(&connection, &database, &error),
+ adbc_validation::IsOkStatus(&error));
+
+ adbc_validation::StreamReader reader;
+ std::vector<uint32_t> info = {
+ ADBC_INFO_DRIVER_NAME,
+ ADBC_INFO_DRIVER_VERSION,
+ ADBC_INFO_VENDOR_NAME,
+ ADBC_INFO_VENDOR_VERSION,
+ };
+ ASSERT_THAT(AdbcConnectionGetInfo(&connection, info.data(), info.size(),
+ &reader.stream.value, &error),
+ adbc_validation::IsOkStatus(&error));
+ ASSERT_NO_FATAL_FAILURE(reader.GetSchema());
+
+ std::vector<uint32_t> seen;
+ while (true) {
+ ASSERT_NO_FATAL_FAILURE(reader.Next());
+ if (!reader.array->release) break;
+
+ for (int64_t row = 0; row < reader.array->length; row++) {
+ ASSERT_FALSE(ArrowArrayViewIsNull(reader.array_view->children[0], row));
+ const uint32_t code =
+ reader.array_view->children[0]->buffer_views[1].data.as_uint32[row];
+ seen.push_back(code);
+
+ int str_child_index = 0;
+ struct ArrowArrayView* str_child =
+ reader.array_view->children[1]->children[str_child_index];
+ switch (code) {
+ case ADBC_INFO_DRIVER_NAME: {
+ ArrowStringView val = ArrowArrayViewGetStringUnsafe(str_child, 0);
+ EXPECT_EQ("ADBC SQLite Driver", std::string(val.data,
val.size_bytes));
+ break;
+ }
+ case ADBC_INFO_DRIVER_VERSION: {
+ ArrowStringView val = ArrowArrayViewGetStringUnsafe(str_child, 1);
+ EXPECT_EQ("(unknown)", std::string(val.data, val.size_bytes));
+ break;
+ }
+ case ADBC_INFO_VENDOR_NAME: {
+ ArrowStringView val = ArrowArrayViewGetStringUnsafe(str_child, 2);
+ EXPECT_EQ("SQLite", std::string(val.data, val.size_bytes));
+ break;
+ }
+ case ADBC_INFO_VENDOR_VERSION: {
+ ArrowStringView val = ArrowArrayViewGetStringUnsafe(str_child, 3);
+ EXPECT_THAT(std::string(val.data, val.size_bytes),
+ ::testing::MatchesRegex("3\\..*"));
Review Comment:
Ideally this could be something like `3\\.\d{1,2}\\.\d{1,2}` but didn't want
to go down a rabbit hole given the cross platform regex differences
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
