lidavidm commented on code in PR #658:
URL: https://github.com/apache/arrow-adbc/pull/658#discussion_r1188545614
##########
c/validation/adbc_validation.cc:
##########
@@ -318,9 +318,6 @@ void ConnectionTest::TestMetadataGetInfo() {
case ADBC_INFO_DRIVER_VERSION:
case ADBC_INFO_VENDOR_NAME:
case ADBC_INFO_VENDOR_VERSION:
- // UTF8
- ASSERT_EQ(uint8_t(0),
-
reader.array_view->children[1]->buffer_views[0].data.as_uint8[row]);
Review Comment:
Ah, I think I remember what this is now. It's checking the union type code.
We should keep this, then...and probably explain it more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
