westonpace commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1187946724
##########
cpp/src/arrow/chunked_array.h:
##########
@@ -263,8 +263,10 @@ Status ApplyBinaryChunked(const ChunkedArray& left, const
ChunkedArray& right,
Action&& action) {
MultipleChunkIterator iterator(left, right);
std::shared_ptr<Array> left_piece, right_piece;
+ int64_t pos = iterator.position();
while (iterator.Next(&left_piece, &right_piece)) {
- ARROW_RETURN_NOT_OK(action(*left_piece, *right_piece,
iterator.position()));
+ ARROW_RETURN_NOT_OK(action(*left_piece, *right_piece, pos));
+ pos = iterator.position();
Review Comment:
Ah, I see. This does appear to be more or less unused outside of test
reporting so perhaps it just wasn't noticed. `MultiChunkIterator::position` is
very unintuitive. However, given its been around a few years, we should
probably leave it alone. Thanks for this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
