westonpace commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1187952001
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -680,6 +816,7 @@ class InputState {
Result<bool> AdvanceAndMemoize(OnType ts) {
// Advance the right side row index until we reach the latest right row
(for each key)
// for the given left timestamp.
+ DEBUG_SYNC(node_, "Advancing input ", index_, DEBUG_MANIP(std::endl));
Review Comment:
`DEBUG_MANIP` is ok. However, I think ending a debug statement with an
endline is going to be more common than not ending with an endline (in fact, if
we don't end with an endline, I don't think we guarantee things are flushed,
and it would still be possible to get interleaved / out of order output). It
would be nice though if there was a `DEBUG_LINE` or `DEBUG_SYNC_LINE` or
something that acted exactly like `DEBUG_SYNC` except it included the endline
for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
