pitrou commented on code in PR #35471:
URL: https://github.com/apache/arrow/pull/35471#discussion_r1188848035
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -1520,6 +1520,9 @@ class AsofJoinNode : public ExecNode {
// Plan has already aborted. Do not start process thread
return Status::OK();
}
+ #ifndef ARROW_ENABLE_THREADING
+ return Status::ExecutionError("ASOF join requires threading enabled");
Review Comment:
Probably move this at the beginning of this method? Also use a `#else`
clause around the regular implementation.
And I would probably make this `Status::NotImplemented`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
