pitrou commented on code in PR #35471:
URL: https://github.com/apache/arrow/pull/35471#discussion_r1188850473
##########
cpp/src/arrow/acero/bloom_filter_test.cc:
##########
@@ -472,8 +472,10 @@ TEST(BloomFilter, Basic) {
std::vector<BloomFilterBuildStrategy> strategy;
strategy.push_back(BloomFilterBuildStrategy::SINGLE_THREADED);
-#ifndef ARROW_VALGRIND
+#ifdef ARROW_ENABLE_THREADING
+#ifndef ARROW_VALGRIND
strategy.push_back(BloomFilterBuildStrategy::PARALLEL);
+#endif
#endif
Review Comment:
Or, more tersely
```suggestion
#if defined(ARROW_ENABLE_THREADING) && !defined(ARROW_VALGRIND)
strategy.push_back(BloomFilterBuildStrategy::PARALLEL);
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
