rtpsw commented on PR #35541: URL: https://github.com/apache/arrow/pull/35541#issuecomment-1544151067
I was thinking along the lines of your work; you're clearly ahead of me on this. > I don't think we need to worry about aligning any buffers with a width of 8 or less We do. In failures I observed internally, the cause was misalignment of buffer addresses (which were even numerically odd) that were expected to be 4- or 8-byte aligned. I think the switch-statement should be refactored into `type_traits.h`, if it ends up as part of the solution. I think the correct idea here is that alignment applies to buffers, not arrays. That is, the format of the buffer is what determines the required alignment, if any, and I guess this format is determined by the buffer index within the array and the array's storage type. @westonpace, should you or I take this forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
