rtpsw commented on PR #35541:
URL: https://github.com/apache/arrow/pull/35541#issuecomment-1544503234

   > Sorry, I meant 8bits or less (e.g. we can safely assume that everything 
has at least 1 byte of alignment)
   
   Agreed. I included this condition in my recent commit here.
   
   > > I think the correct idea here is that alignment applies to buffers, not 
arrays.
   > 
   > Yes, unfortunately.
   
   I'd suggest considering adding something like 
`DataType::GetBufferAlignment(int index)` to return the required alignment of  
buffer at `index` that must be a power-of-2 or otherwise be 0 for when no 
alignment is required. This would force any future data type to provide this 
info.
   
   > Sorry to steal a task
   
   OK, you owe me one :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to