aprimadi commented on code in PR #4201:
URL: https://github.com/apache/arrow-rs/pull/4201#discussion_r1191508234
##########
arrow-cast/src/cast.rs:
##########
@@ -2123,6 +2147,41 @@ pub fn cast_with_options(
}
}
+/// Parses a fixed offset of the form "+09:00", "-09" or "+0930"
+fn parse_offset_secs(tz: &str) -> Result<i64, ArrowError> {
Review Comment:
This is copied from `arrow-array/src/timezone.rs` with some modification.
The function there is private so yeah not sure if this should belong to
`arrow-cast/src/parse.rs` or here or need to refactor it into a common function.
I just thought that doing arithmetic operation instead of passing long
datetime function will help with the SIMD or LLVM but then I'm kinda new to
this so yeah not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
