tustvold commented on code in PR #4201:
URL: https://github.com/apache/arrow-rs/pull/4201#discussion_r1192291423
##########
arrow-cast/src/cast.rs:
##########
@@ -6114,6 +6127,97 @@ mod tests {
assert!(result.is_null(2));
}
+ // See: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones for
list of valid
+ // timezones
+
+ // Cast Timestamp(_, None) -> Timestamp(_, Some(timezone))
+ #[cfg(feature = "chrono-tz")]
Review Comment:
I think these need to be moved to arrow/tests/array_cast.rs as `chrono-tz`
isn't a feature of this crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
