alexandreyc opened a new pull request, #4221:
URL: https://github.com/apache/arrow-rs/pull/4221
# Which issue does this PR close?
This PR does not close any particular issue.
# Rationale for this change
After adding the `RecordBatchWriter` trait in #4206, I realized that one
more method was needed to be able to work generically with writers. Almost
every existing writers (except CSV) have some kind of method to close/finish
the writer that must be called after all calls to `write` have been made.
# What changes are included in this PR?
Add `RecordBatchWriter::finish` method and implement it for CSV, JSON, IPC
and Parquet.
# Are there any user-facing changes?
Yes. According to my analysis there are at least two breaking changes:
- `parquet::arrow::arrow_writer::ArrowWriter::close` now takes `&mut self`
instead of `self`
- `parquet::file::writer::SerializedFileWriter::close` now takes `&mut self`
instead of `self`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
