tustvold commented on code in PR #4221:
URL: https://github.com/apache/arrow-rs/pull/4221#discussion_r1194421092
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -240,7 +241,7 @@ impl<W: Write> ArrowWriter<W> {
}
/// Close and finalize the underlying Parquet writer
- pub fn close(mut self) -> Result<crate::format::FileMetaData> {
+ pub fn close(&mut self) -> Result<crate::format::FileMetaData> {
Review Comment:
This API is intentionally consuming, as otherwise the lifetime scoping is
very cumbersome, is there some way to avoid this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
