sgilmore10 commented on code in PR #35551:
URL: https://github.com/apache/arrow/pull/35551#discussion_r1195384150
##########
matlab/src/cpp/arrow/matlab/array/proxy/array.cc:
##########
@@ -23,7 +23,7 @@ namespace arrow::matlab::array::proxy {
// Register Proxy methods.
REGISTER_METHOD(Array, ToString);
- REGISTER_METHOD(Array, ToMatlab);
+ REGISTER_METHOD(Array, toMATLAB);
Review Comment:
1. Changed `ToString` to `toString`.
2. Also renamed the c++ method `Length()` `length()`. However, since this
`Length` is a property on the MATLAB `arrow.array.Array` class, I left the
property name alone. In MATLAB, property names are typically upper camel case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
