icexelloss commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1195636564
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -821,7 +977,8 @@ struct CompositeReferenceRow {
template <size_t MAX_TABLES>
class CompositeReferenceTable {
public:
- explicit CompositeReferenceTable(size_t n_tables) : n_tables_(n_tables) {
+ CompositeReferenceTable(AsofJoinNode& node, size_t n_tables)
Review Comment:
I do think a `DebugContext` (or maybe some other name) that contains the
needed variable here (the pointer to the AsofJoinNode or other information)
make the code more clear and readable. Otherwise, for every class function that
takes a AsofJoinNode, the reader needs to think about "Is the node needed here
just for debug or for something else".
If there is already other debug related stuff such as stream and mutex, can
we create one class to contain all debug related stuff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
