icexelloss commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1195640485
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -821,7 +977,8 @@ struct CompositeReferenceRow {
template <size_t MAX_TABLES>
class CompositeReferenceTable {
public:
- explicit CompositeReferenceTable(size_t n_tables) : n_tables_(n_tables) {
+ CompositeReferenceTable(AsofJoinNode& node, size_t n_tables)
Review Comment:
Actually DebugOptions looks like it needs to be passed from the caller. We
can do sth like
```
struct DebugContext {
// Need information from the node class for debugging message
AsofJoinNode* node;
}
```
And pass that object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
