rtpsw commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1196050109
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -821,7 +977,8 @@ struct CompositeReferenceRow {
template <size_t MAX_TABLES>
class CompositeReferenceTable {
public:
- explicit CompositeReferenceTable(size_t n_tables) : n_tables_(n_tables) {
+ CompositeReferenceTable(AsofJoinNode& node, size_t n_tables)
Review Comment:
The [recent
commit](https://github.com/apache/arrow/pull/34392/commits/e418422b6d025c1093bf49510f42c3a568dab78b)
makes debug-arguments clear not only at declarations but also at call-sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
