rtpsw commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1196441869
##########
cpp/src/arrow/acero/options.h:
##########
@@ -52,13 +52,21 @@ class Executor;
namespace acero {
+#ifndef NDEBUG
+struct DebugOptions;
+#endif
+
using AsyncExecBatchGenerator = AsyncGenerator<std::optional<ExecBatch>>;
/// \addtogroup execnode-options
/// @{
class ARROW_ACERO_EXPORT ExecNodeOptions {
public:
virtual ~ExecNodeOptions() = default;
+
+#ifndef NDEBUG
+ std::shared_ptr<DebugOptions> debug_opts;
+#endif
Review Comment:
I'm not sure how to solve this nicely. Could you make a suggestion?
Not-so-nice solutions I see are:
1. Change to a `std::shared_ptr<BaseOptions>` with `DebugOptions` deriving
from `BaseOptions`.
2. Expose `DebugOptions` in release-mode too (but not use it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
