tustvold commented on code in PR #4225:
URL: https://github.com/apache/arrow-rs/pull/4225#discussion_r1196329815
##########
object_store/src/azure/credential.rs:
##########
@@ -338,13 +342,15 @@ impl ClientSecretOAuthProvider {
}
#[async_trait::async_trait]
-impl TokenCredential for ClientSecretOAuthProvider {
+impl TokenProvider for ClientSecretOAuthProvider {
+ type Credential = AzureCredential;
+
/// Fetch a token
async fn fetch_token(
&self,
client: &Client,
retry: &RetryConfig,
- ) -> Result<TemporaryToken<String>> {
+ ) -> crate::Result<TemporaryToken<Arc<AzureCredential>>> {
Review Comment:
I think I prefer being explicit about the type returned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
