pitrou commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1196416451
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -821,7 +984,8 @@ struct CompositeReferenceRow {
template <size_t MAX_TABLES>
class CompositeReferenceTable {
public:
- explicit CompositeReferenceTable(size_t n_tables) : n_tables_(n_tables) {
+ NDEBUG_EXPLICIT CompositeReferenceTable(DEBUG_ADD(size_t n_tables,
AsofJoinNode& node))
Review Comment:
Same here and in other places as well: use a pointer for non-const
references.
```suggestion
NDEBUG_EXPLICIT CompositeReferenceTable(DEBUG_ADD(size_t n_tables,
AsofJoinNode* node))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
