pitrou commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1196478731
##########
cpp/src/arrow/acero/options.h:
##########
@@ -52,13 +52,21 @@ class Executor;
namespace acero {
+#ifndef NDEBUG
+struct DebugOptions;
+#endif
+
using AsyncExecBatchGenerator = AsyncGenerator<std::optional<ExecBatch>>;
/// \addtogroup execnode-options
/// @{
class ARROW_ACERO_EXPORT ExecNodeOptions {
public:
virtual ~ExecNodeOptions() = default;
+
+#ifndef NDEBUG
+ std::shared_ptr<DebugOptions> debug_opts;
+#endif
Review Comment:
Sounds ok to me. But I wonder why debug options would be ignored in release
mode. Someone may be using a release build of Arrow and still want to add
optional debugging from time to time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
