pitrou commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1196714547
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -268,11 +394,12 @@ struct MemoStore {
} else {
future_entries_[key].emplace(time, batch, row);
}
- if (!no_future_ || times_.empty() || times_.front() != time) {
+ if (times_.empty() || (!no_future_ && times_.back() != time)) {
Review Comment:
It looks like this logic is delicate enough that you had to change it, so
can you perhaps add a comment explaining it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
