lidavidm commented on code in PR #686:
URL: https://github.com/apache/arrow-adbc/pull/686#discussion_r1196740281
##########
go/adbc/adbc.go:
##########
@@ -536,3 +536,16 @@ type Statement interface {
// an error with a StatusNotImplemented code.
ExecutePartitions(context.Context) (*arrow.Schema, Partitions, int64,
error)
}
+
+// Statement110 is an extension interface for methods added to Statement in
+// ADBC API revision 1.1.0.
+type Statement110 interface {
+ Statement
+
+ // ExecuteSchema returns the schema of the result set of a query without
+ // executing it.
+ //
+ // If the driver does not support this, this will return an error with a
+ // StatusNotImplemented code.
+ ExecuteSchema(context.Context) (*arrow.Schema, error)
+}
Review Comment:
Well, we're going to have more methods - but I can remove the embedding and
we can append more methods to the new interface while on the branch.
Or if we end up going for 2.0.0 we can just add them to the original
interface. (Frankly since the compatibility concerns are different we could
just go down that path anyways?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
