zeroshade commented on code in PR #686:
URL: https://github.com/apache/arrow-adbc/pull/686#discussion_r1196764667
##########
go/adbc/adbc.go:
##########
@@ -536,3 +536,16 @@ type Statement interface {
// an error with a StatusNotImplemented code.
ExecutePartitions(context.Context) (*arrow.Schema, Partitions, int64,
error)
}
+
+// Statement110 is an extension interface for methods added to Statement in
+// ADBC API revision 1.1.0.
+type Statement110 interface {
+ Statement
+
+ // ExecuteSchema returns the schema of the result set of a query without
+ // executing it.
+ //
+ // If the driver does not support this, this will return an error with a
+ // StatusNotImplemented code.
+ ExecuteSchema(context.Context) (*arrow.Schema, error)
+}
Review Comment:
well, I still want to avoid breaking changes unless we're bumping the
version number. but if we bump the version number then you're correct that we
don't need to worry about ABI compatibility and can just bump the version
number of the package and add to the original interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
