tustvold commented on code in PR #6412:
URL: https://github.com/apache/arrow-datafusion/pull/6412#discussion_r1200822085
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -33,7 +32,12 @@ use datafusion_common::{DataFusionError, Result};
use datafusion_expr::ColumnarValue;
/// provide DataFusion default cast options
-pub const DEFAULT_DATAFUSION_CAST_OPTIONS: CastOptions = CastOptions { safe:
false };
Review Comment:
This change is necessary because FormatOptions isn't const constructible, it
is somewhat an accident that CastOptions has historically been - any
non-trivial additional options would have broken this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
