tustvold commented on code in PR #6412:
URL: https://github.com/apache/arrow-datafusion/pull/6412#discussion_r1201013788
##########
datafusion/core/tests/sqllogictests/test_files/set_variable.slt:
##########
@@ -193,31 +193,31 @@ SET TIME ZONE = '+08:00'
query P
SELECT '2000-01-01T00:00:00'::TIMESTAMP::TIMESTAMPTZ
----
-2000-01-01T08:00:00+08:00
+1999-12-31T16:00:00+08:00
Review Comment:
Ok I am fairly certain this is a bug in the scalar value logic
```
❯ create table foo (ts text) as values ('2000-01-01T00:00:00');
❯ select * from foo;
+---------------------+
| ts |
+---------------------+
| 2000-01-01T00:00:00 |
+---------------------+
# This is correct
❯ select arrow_cast(ts, 'Timestamp(Nanosecond, Some( "+08:00" ))') from foo;
+---------------------------+
| foo.ts |
+---------------------------+
| 2000-01-01T00:00:00+08:00 |
+---------------------------+
# This is incorrect
❯ select arrow_cast('2000-01-01T00:00:00', 'Timestamp(Nanosecond, Some(
"+08:00" ))') from foo;
+-----------------------------+
| Utf8("2000-01-01T00:00:00") |
+-----------------------------+
| 1999-12-31T16:00:00+08:00 |
+-----------------------------+
1 row in set. Query took 0.002 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
