felipecrv commented on code in PR #35565: URL: https://github.com/apache/arrow/pull/35565#discussion_r1201292353
########## cpp/src/arrow/acero/exec_plan.cc: ########## @@ -358,10 +359,38 @@ std::optional<int> GetNodeIndex(const std::vector<ExecNode*>& nodes, return std::nullopt; } +const std::string kAceroAlignmentHandlingEnvVar = "ACERO_ALIGNMENT_HANDLING"; Review Comment: C-style string as suggested by the linter is better for constants. And that's what `GetEnvVar` takes under-the hood, so a heap-alloc for std::string never happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
