felipecrv commented on code in PR #35565:
URL: https://github.com/apache/arrow/pull/35565#discussion_r1201294341
##########
cpp/src/arrow/type_traits.cc:
##########
@@ -86,9 +86,13 @@ int RequiredValueAlignmentForBuffer(Type::type type_id, int
buffer_index) {
case Type::DICTIONARY:
case Type::EXTENSION:
case Type::MAX_ID:
- Status::Invalid("Could not check alignment for type id ",
type_id).Warn();
+ Status::Invalid("RequiredValueAlignmentForBuffer called with invalid
type id ",
+ type_id)
+ .Warn();
Review Comment:
You could put a `break` here and move this message to where you added the
other status before the `return 1` at the end. Both situations are only
possible with invalid arguments being passed anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
