mapleFU commented on code in PR #35731:
URL: https://github.com/apache/arrow/pull/35731#discussion_r1203501239
##########
cpp/src/parquet/hasher.h:
##########
@@ -66,6 +66,58 @@ class Hasher {
/// @param len the value length.
virtual uint64_t Hash(const FLBA* value, uint32_t len) const = 0;
+ /// Batch compute hashes for 32 bits values by using its plain encoding
result.
+ ///
+ /// @param values the value to hash.
+ /// @param num_values the number of values to hash.
+ /// @param hashes the output hash value, it length should be equal to
num_values.
+ virtual void Hashes(const int32_t* values, int num_values, uint64_t* hashes)
const = 0;
Review Comment:
I don't know ... They're all ok for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
