pitrou commented on code in PR #35731:
URL: https://github.com/apache/arrow/pull/35731#discussion_r1203848528
##########
cpp/src/parquet/xxhasher.cc:
##########
@@ -27,6 +27,14 @@ template <typename T>
uint64_t XxHashHelper(T value, uint32_t seed) {
return XXH64(reinterpret_cast<const void*>(&value), sizeof(T), seed);
}
+
+template <typename T>
+void XxHashesHelper(const T* value, uint32_t seed, int num_values, uint64_t*
results) {
+ for (int i = 0; i < num_values; ++i) {
+ results[i] = XxHashHelper(value[i], seed);
+ }
Review Comment:
Nit
```suggestion
void XxHashesHelper(const T* values, uint32_t seed, int num_values,
uint64_t* results) {
for (int i = 0; i < num_values; ++i) {
results[i] = XxHashHelper(values[i], seed);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
