berkaysynnada opened a new pull request, #6433:
URL: https://github.com/apache/arrow-datafusion/pull/6433
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #6155.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
https://github.com/apache/arrow-datafusion/pull/6196 PR has solved the issue
of temporal scalars cannot appear as the LHS argument in an arithmetic
operation. But there is an unoptimized solution such as creating an array from
a scalar value as the length of the RHS array, and apply array vs array
operations. This PR solves this issue in a similar way of LHS:Array and
RHS:Scalar arithmetic.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
In the datetime.rs, there are two functions that handle arithmetic
operations between arrays and arrays, and between scalars and arrays. To
determine the appropriate operation to perform, a flag is used to hold
information about the left-hand side (LHS) and right-hand side (RHS) operands.
In the kernel_arrow.rs, type matching is performed to identify the specific
operation to execute. Finally, the actual computation is carried out in the
corresponding function within the binary.rs.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
