ozankabak commented on code in PR #6433:
URL: https://github.com/apache/arrow-datafusion/pull/6433#discussion_r1206000707
##########
datafusion/physical-expr/src/expressions/binary/kernels_arrow.rs:
##########
@@ -333,34 +337,88 @@ pub(crate) fn add_dyn_temporal(left: &ArrayRef, right:
&ArrayRef) -> Result<Arra
}
}
-pub(crate) fn add_dyn_temporal_scalar(
+pub(crate) fn add_dyn_temporal_right_scalar(
Review Comment:
A question that comes to my mind about this approach is whether the unary
minus on the LHS (the array) would result in unnecessary computation or not.
Given the complexity of the types involved, I am not sure if the compiler would
be smart enough to optimize things all the way and emit simple subtraction code
(vs. negating the entire array and then summing again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
