pitrou commented on code in PR #35565: URL: https://github.com/apache/arrow/pull/35565#discussion_r1205264909
########## cpp/src/arrow/util/align_util.cc: ########## @@ -94,12 +135,17 @@ bool CheckAlignment(const Table& table, int64_t alignment, return all_aligned; } +// Most allocators require a minimum of 8-byte alignment. +constexpr int64_t kMinimumAlignment = 8; Review Comment: Hmm, we should fix our wrapper around `posix_memalign` then, IMHO. I think we should also use `max(kDefaultBufferAlignment, alignment)` in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
