westonpace commented on code in PR #35565:
URL: https://github.com/apache/arrow/pull/35565#discussion_r1205261850
##########
cpp/src/arrow/util/align_util.cc:
##########
@@ -112,10 +158,17 @@ Result<std::shared_ptr<ArrayData>>
EnsureAlignment(std::shared_ptr<ArrayData> ar
MemoryPool* memory_pool) {
if (!CheckAlignment(*array_data, alignment)) {
std::vector<std::shared_ptr<Buffer>> buffers_ = array_data->buffers;
Review Comment:
Good catch. I've fixed this.
##########
cpp/src/arrow/type_traits.h:
##########
@@ -1309,6 +1309,28 @@ static inline int offset_bit_width(Type::type type_id) {
return 0;
}
+/// \brief get the alignment a buffer should have to be considered "value
aligned"
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
