kevingurney commented on code in PR #35655:
URL: https://github.com/apache/arrow/pull/35655#discussion_r1205848529
##########
matlab/src/cpp/arrow/matlab/array/proxy/numeric_array.h:
##########
@@ -68,12 +81,11 @@ class NumericArray : public
arrow::matlab::array::proxy::Array {
auto data_buffer =
std::make_shared<arrow::Buffer>(reinterpret_cast<const uint8_t*>(dt),
sizeof(CType) *
numeric_mda.getNumberOfElements());
- // TODO: Implement null support
- std::shared_ptr<arrow::Buffer> null_buffer = nullptr;
+ // Pack the validity bitmap values.
+ auto packed_validity_bitmap = has_validity_bitmap ?
arrow::matlab::bit::bitPackMatlabLogicalArray(constructor_arguments[2]).ValueOrDie()
: nullptr;
Review Comment:
That's a very good point!
We need to add a bit more infrastructure to mathworks/libmexclass to make
exception handling more straightforward. So, it might be easier if we follow up
with a separate pull request to handle this after updating libmexclass.
We have been exploring a few different approaches to error handling in
libmexclass, but we haven't decided which one makes the most sense yet. We know
this is something that needs to be prioritized in the near term.
I've captured this in https://github.com/apache/arrow/issues/35768.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
