kevingurney commented on code in PR #35655:
URL: https://github.com/apache/arrow/pull/35655#discussion_r1205925169
##########
matlab/src/cpp/arrow/matlab/array/proxy/array.cc:
##########
@@ -40,4 +43,25 @@ namespace arrow::matlab::array::proxy {
auto length_mda = factory.createScalar(array->length());
context.outputs[0] = length_mda;
}
+
+ void Array::valid(libmexclass::proxy::method::Context& context) {
+ size_t array_length = static_cast<size_t>(array->length());
+
+ // If the Arrow array has no null values, then return a MATLAB
+ // logical array that is all "true" for the validity bitmap.
+ if (array->null_count() == 0) {
+ ::matlab::data::ArrayFactory factory;
+ auto validity_buffer = factory.createBuffer<bool>(array_length);
+ auto validity_buffer_ptr = validity_buffer.get();
+ std::fill(validity_buffer_ptr, validity_buffer_ptr + array_length,
true);
+ ::matlab::data::TypedArray<bool> valid_elements_mda =
factory.createArrayFromBuffer<bool>({array_length, 1},
std::move(validity_buffer));
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
