LouisGariepy opened a new pull request, #6465: URL: https://github.com/apache/arrow-datafusion/pull/6465
# Which issue does this PR close? Closes #6437. # Rationale for this change Some operators on `Expr` are duplicated between type methods and trait impls. This PR removes the duplicated operators in favor of the trait impls. See #6437 for a more in-depth explanation of why this should be fixed. # What changes are included in this PR? Moved the `Not` trait impl to the `operator` module. Removed the duplicate type methods. Fixed calls to the removed methods to use the corresponding trait method in instances where the two method names were not the same. # Are these changes tested? No features were added or removed, so the existing tests should be OK. I removed a now useless test case for the `Not` trait impl, and added a new one in the `operator` module's unit tests. The new test was made in the same style as the other existing operator unit tests. # Are there any user-facing changes? Yes, some operator methods have now changed names (when the type methods and the corresponding trait method did not have the same name), and they will now require the relevant trait to be imported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
