2010YOUY01 commented on code in PR #6479:
URL: https://github.com/apache/arrow-datafusion/pull/6479#discussion_r1209612618
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -429,31 +341,130 @@ impl BuiltinScalarFunction {
}
}
-impl fmt::Display for BuiltinScalarFunction {
- fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
- for (func_name, func) in NAME_TO_FUNCTION.iter() {
- if func == self {
- return write!(f, "{}", func_name);
- }
+fn aliases(func: &BuiltinScalarFunction) -> &'static [&'static str] {
Review Comment:
Sorry I commented on the wrong line previously @comphead , should be here.
Adding a comment for aliases():
`/// First alias in the array is used to display function names`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
