alamb commented on code in PR #6479:
URL: https://github.com/apache/arrow-datafusion/pull/6479#discussion_r1210281705
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -429,31 +341,130 @@ impl BuiltinScalarFunction {
}
}
-impl fmt::Display for BuiltinScalarFunction {
- fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
- for (func_name, func) in NAME_TO_FUNCTION.iter() {
- if func == self {
- return write!(f, "{}", func_name);
- }
+fn aliases(func: &BuiltinScalarFunction) -> &'static [&'static str] {
+ match func {
+ BuiltinScalarFunction::Abs => &["abs"],
+ BuiltinScalarFunction::Acos => &["acos"],
+ BuiltinScalarFunction::Acosh => &["acosh"],
+ BuiltinScalarFunction::Asin => &["asin"],
+ BuiltinScalarFunction::Asinh => &["asinh"],
+ BuiltinScalarFunction::Atan => &["atan"],
+ BuiltinScalarFunction::Atanh => &["atanh"],
+ BuiltinScalarFunction::Atan2 => &["atan2"],
+ BuiltinScalarFunction::Cbrt => &["cbrt"],
+ BuiltinScalarFunction::Ceil => &["ceil"],
+ BuiltinScalarFunction::Cos => &["cos"],
+ BuiltinScalarFunction::Cosh => &["cosh"],
+ BuiltinScalarFunction::Degrees => &["degrees"],
+ BuiltinScalarFunction::Exp => &["exp"],
+ BuiltinScalarFunction::Factorial => &["factorial"],
+ BuiltinScalarFunction::Floor => &["floor"],
+ BuiltinScalarFunction::Gcd => &["gcd"],
+ BuiltinScalarFunction::Lcm => &["lcm"],
+ BuiltinScalarFunction::Ln => &["ln"],
+ BuiltinScalarFunction::Log => &["log"],
+ BuiltinScalarFunction::Log10 => &["log10"],
+ BuiltinScalarFunction::Log2 => &["log2"],
+ BuiltinScalarFunction::Pi => &["pi"],
+ BuiltinScalarFunction::Power => &["power", "pow"],
+ BuiltinScalarFunction::Radians => &["radians"],
+ BuiltinScalarFunction::Random => &["random"],
+ BuiltinScalarFunction::Round => &["round"],
+ BuiltinScalarFunction::Signum => &["signum"],
+ BuiltinScalarFunction::Sin => &["sin"],
+ BuiltinScalarFunction::Sinh => &["sinh"],
+ BuiltinScalarFunction::Sqrt => &["sqrt"],
+ BuiltinScalarFunction::Tan => &["tan"],
+ BuiltinScalarFunction::Tanh => &["tanh"],
+ BuiltinScalarFunction::Trunc => &["trunc"],
+
+ // conditional functions
+ BuiltinScalarFunction::Coalesce => &["coalesce"],
+ BuiltinScalarFunction::NullIf => &["nullif"],
+
+ // string functions
+ BuiltinScalarFunction::Ascii => &["ascii"],
+ BuiltinScalarFunction::BitLength => &["bit_length"],
+ BuiltinScalarFunction::Btrim => &["btrim"],
+ BuiltinScalarFunction::CharacterLength => {
+ &["character_length", "char_length", "length"]
}
+ BuiltinScalarFunction::Concat => &["concat"],
+ BuiltinScalarFunction::ConcatWithSeparator => &["concat_ws"],
+ BuiltinScalarFunction::Chr => &["chr"],
+ BuiltinScalarFunction::InitCap => &["initcap"],
+ BuiltinScalarFunction::Left => &["left"],
+ BuiltinScalarFunction::Lower => &["lower"],
+ BuiltinScalarFunction::Lpad => &["lpad"],
+ BuiltinScalarFunction::Ltrim => &["ltrim"],
+ BuiltinScalarFunction::OctetLength => &["octet_length"],
+ BuiltinScalarFunction::Repeat => &["repeat"],
+ BuiltinScalarFunction::Replace => &["replace"],
+ BuiltinScalarFunction::Reverse => &["reverse"],
+ BuiltinScalarFunction::Right => &["right"],
+ BuiltinScalarFunction::Rpad => &["rpad"],
+ BuiltinScalarFunction::Rtrim => &["rtrim"],
+ BuiltinScalarFunction::SplitPart => &["split_part"],
+ BuiltinScalarFunction::StartsWith => &["starts_with"],
+ BuiltinScalarFunction::Strpos => &["strpos"],
+ BuiltinScalarFunction::Substr => &["substr"],
+ BuiltinScalarFunction::ToHex => &["to_hex"],
+ BuiltinScalarFunction::Translate => &["translate"],
+ BuiltinScalarFunction::Trim => &["trim"],
+ BuiltinScalarFunction::Upper => &["upper"],
+ BuiltinScalarFunction::Uuid => &["uuid"],
+
+ // regex functions
+ BuiltinScalarFunction::RegexpMatch => &["regexp_match"],
+ BuiltinScalarFunction::RegexpReplace => &["regexp_replace"],
+
+ // time/date functions
+ BuiltinScalarFunction::Now => &["now"],
+ BuiltinScalarFunction::CurrentDate => &["current_date"],
+ BuiltinScalarFunction::CurrentTime => &["current_time"],
+ BuiltinScalarFunction::DateBin => &["date_bin"],
+ BuiltinScalarFunction::DateTrunc => &["date_trunc", "datetrunc"],
Review Comment:
I like how this formulation makes it easier to understand what functions
have aliases and which do not 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
