mustafasrepo commented on code in PR #6482: URL: https://github.com/apache/arrow-datafusion/pull/6482#discussion_r1210004714
########## datafusion/core/tests/sqllogictests/test_files/groupby.slt: ########## @@ -2029,10 +2029,10 @@ SELECT a, b, FIRST_VALUE(c ORDER BY a DESC) as first_c FROM annotated_data_infinite2 GROUP BY a, b ---- -0 0 0 -0 1 25 -1 2 50 -1 3 75 +0 0 24 Review Comment: Since ordering requirement column `a` is inside the group by expressions. Each group consists of single value for column `a`. Hence previous result, and this result are both correct. However, with the changes in this PR, result changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
