mustafasrepo commented on code in PR #6482:
URL: https://github.com/apache/arrow-datafusion/pull/6482#discussion_r1212727878
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -397,14 +454,111 @@ fn is_order_sensitive(aggr_expr: &Arc<dyn
AggregateExpr>) -> bool {
|| aggr_expr.as_any().is::<ArrayAgg>()
}
+/// Calculate the required input ordering for the [`AggregateExec`] by
considering
Review Comment:
I moved this utils function to
[file](https://github.com/apache/arrow-datafusion/blob/main/datafusion/physical-expr/src/aggregate/mod.rs)
where `AggregateExpr` trait is defined. Thanks for the suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
