alamb commented on code in PR #6487:
URL: https://github.com/apache/arrow-datafusion/pull/6487#discussion_r1210352535
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -2448,6 +2448,16 @@ mod tests {
regex_not_match(col("c1"), lit("^foo$")),
col("c1").not_eq(lit("foo")),
);
+ assert_change(
Review Comment:
Could you also add some tests for cases like the following as a way to try
and get some more test coverage on the regexp matching code?
1. `"(foo|bar)"` (expect no rewrite)
1. `"(foo|bar)*"` (expect no rewrite)
1. `"^(foo|bar)*"` (expect no rewrite)
2. `"^(foo)$"`
3. "^(foo|bar|baz)$"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
