jackwener commented on PR #6487:
URL:
https://github.com/apache/arrow-datafusion/pull/6487#issuecomment-1571579675
Because your branch is `main`, so I can't push my patch into it.
```
! [remote rejected] tanruixiang/main -> tanruixiang/main (permission
denied)
error: failed to push some refs to
'https://github.com/tanruixiang/arrow-datafusion.git'
```
Please rebase to latest code.
And add this patch.
```
Subject: [PATCH] fix unit test
---
Index: datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git
a/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
b/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
--- a/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
(revision 1afab5c652b0273e3517bc5d5089e465c1983166)
+++ b/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
(revision c9d56044a9457d8bd0cb59cda4e6895bb56492be)
@@ -2482,13 +2482,13 @@
// regular expressions that match exact captured literals
assert_change(
regex_match(col("c1"), lit("^(foo|bar)$")),
- col("c1").eq(lit("bar")).or(col("c1").eq(lit("foo"))),
+ col("c1").eq(lit("foo")).or(col("c1").eq(lit("bar"))),
);
assert_change(
regex_not_match(col("c1"), lit("^(foo|bar)$")),
col("c1")
- .not_eq(lit("bar"))
- .and(col("c1").not_eq(lit("foo"))),
+ .not_eq(lit("foo"))
+ .and(col("c1").not_eq(lit("bar"))),
);
assert_change(
regex_match(col("c1"), lit("^(foo)$")),
@@ -2497,8 +2497,9 @@
assert_change(
regex_match(col("c1"), lit("^(foo|bar|baz)$")),
col("c1")
- .eq(lit("baz"))
-
.or((col("c1").eq(lit("bar"))).or(col("c1").eq(lit("foo")))),
+ .eq(lit("foo"))
+ .or(col("c1").eq(lit("bar")))
+ .or(col("c1").eq(lit("baz"))),
);
assert_change(
regex_match(col("c1"), lit("^(foo|bar|baz|qux)$")),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
