arthurpassos commented on code in PR #35825: URL: https://github.com/apache/arrow/pull/35825#discussion_r1210589696
########## cpp/src/arrow/array/builder_dict.h: ########## @@ -724,6 +747,7 @@ using BinaryDictionaryBuilder = DictionaryBuilder<BinaryType>; using StringDictionaryBuilder = DictionaryBuilder<StringType>; using BinaryDictionary32Builder = Dictionary32Builder<BinaryType>; using StringDictionary32Builder = Dictionary32Builder<StringType>; +using BinaryDictionary64Builder = Dictionary64Builder<LargeBinaryType>; Review Comment: Tbh, I do not have the exact answer for you. I am very new to this code base. My best bet would be: I had to create a LARGE* version of `ByteArrayChunkedRecordReader`. The `ByteArrayChunkedRecordReader` class contains a `::arrow::BinaryDictionary32Builder` instance, so I thought the `Large` version would require a 64 bit version of it. Do you think it's not actually necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
