pitrou commented on code in PR #35825: URL: https://github.com/apache/arrow/pull/35825#discussion_r1210609854
########## cpp/src/arrow/array/builder_dict.h: ########## @@ -724,6 +747,7 @@ using BinaryDictionaryBuilder = DictionaryBuilder<BinaryType>; using StringDictionaryBuilder = DictionaryBuilder<StringType>; using BinaryDictionary32Builder = Dictionary32Builder<BinaryType>; using StringDictionary32Builder = Dictionary32Builder<StringType>; +using BinaryDictionary64Builder = Dictionary64Builder<LargeBinaryType>; Review Comment: @emkornfield What would you suggest here? It seems to me that if a large binary type is desired, it's probably not a good idea to use dictionary encoding... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
