westonpace opened a new pull request, #35860:
URL: https://github.com/apache/arrow/pull/35860

   ### Rationale for this change
   
   The dataset write node previously allowed you to specify custom key/value 
metadata on a write node.  This was added to support saving schema metadata.  
However, it doesn't capture field metadata or field nullability.  This PR 
replaces that capability with the ability to specify a custom schema instead.  
The custom schema must have the same number of fields as the input to the write 
node and each field must have the same type.
   
   ### What changes are included in this PR?
   
   Added `custom_schema` to `WriteNodeOptions` and removed `custom_metadata`.
   
   ### Are these changes tested?
   
   Yes, I added a new C++ unit test to verify that the custom info is applied 
to written files.
   
   ### Are there any user-facing changes?
   
   BREAKING CHANGE: `WriteNodeOptions::custom_metadata` is now 
`WriteNodeOptions::custom_schema`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to