jorisvandenbossche commented on code in PR #35860:
URL: https://github.com/apache/arrow/pull/35860#discussion_r1212891709
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -463,15 +463,21 @@ struct ARROW_DS_EXPORT FileSystemDatasetWriteOptions {
/// \brief Wraps FileSystemDatasetWriteOptions for consumption as
compute::ExecNodeOptions
class ARROW_DS_EXPORT WriteNodeOptions : public acero::ExecNodeOptions {
public:
- explicit WriteNodeOptions(
- FileSystemDatasetWriteOptions options,
- std::shared_ptr<const KeyValueMetadata> custom_metadata = NULLPTR)
- : write_options(std::move(options)),
custom_metadata(std::move(custom_metadata)) {}
+ explicit WriteNodeOptions(FileSystemDatasetWriteOptions options,
+ std::shared_ptr<Schema> custom_schema = NULLPTR)
+ : write_options(std::move(options)),
custom_schema(std::move(custom_schema)) {}
/// \brief Options to control how to write the dataset
FileSystemDatasetWriteOptions write_options;
- /// \brief Optional metadata to attach to written batches
- std::shared_ptr<const KeyValueMetadata> custom_metadata;
Review Comment:
Instead of removing this option (as a breaking change), we could in theory
still allow the user to specify one of both?
(I am not using the C++ API for this, so I don't know how useful this would
be / how cumbersome it is to specify the schema if you only want to specify
metadata. From the DatasetWriter point of view, this is a fine change of course
since there we already have the full schema)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
